ExitWithError() - pod_xxx tests #22552
Conversation
openshift-ci
bot
added
release-note-none
approved
edsantiago
force-pushed
the
exitwitherror-part3
branch
from
95f9b7f to
79ad900
Compare
edsantiago
force-pushed
the
exitwitherror-part3
branch
from
79ad900 to
c68024c
Compare
| if IsRemote() { | ||
| expect = `no such pod "foobar"` |
There was a problem hiding this comment.
I love conditionals. I love inconsistent error messages. They make life so interesting.
|
The nondeterministic error messages are wierd - I don't see how those could be racing. |
edsantiago
force-pushed
the
exitwitherror-part3
branch
from
c68024c to
54087f8
Compare
we run the removal jobs in parallel. Could it depend from that? |
edsantiago
force-pushed
the
exitwitherror-part3
branch
from
54087f8 to
88e26ee
Compare
Followup to containers#22270: wherever possible/practical, extend command error checks to include explicit exit status codes and error strings. This commit handles a subset of test/e2e/pod_xxxx_test.go (I stopped before this grew too huge for review) Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
exitwitherror-part3
branch
from
88e26ee to
275c068
Compare
Yes, if it's on a PR, click (or find) the historical commit ID in question. For example in this PR there's 79ad900df95f1e36bc60d1904ca5e716acf24eb9. In the upper-left of the commit title will be a Red X or green check you can use to interact with any Github check that ran vs that commit. For branches it's a bit trickier, but the technique is the same: Find the commit. |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Followup to #22270: wherever possible/practical, extend command
error checks to include explicit exit status codes and error strings.
This commit handles a subset of test/e2e/pod_xxxx_test.go
(I stopped before this grew too huge for review)
Signed-off-by: Ed Santiago santiago@redhat.com