Unconditionally refresh storage options from config #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
Hm. Is it auto-approving PRs from approvers? |
|
LGTM |
|
LGTM Branch tested on Arch Linux and behaves as expected. |
|
/retest |
|
it seems to break the creation of Reproducer: $ rm ~/.config/containers/storage.conf
$ bin/podman run --rm -ti alpine echo hi
$ cat ~/.config/containers/storage.conf
cat: /home/gscrivano/.config/containers/storage.conf: No such file or directory |
giuseppe
reviewed
Feb 6, 2019
mheon
force-pushed
the
force_storage_refresh
branch
from
1e2f31d to
e46c549
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/retest |
Due to our unconditionally setting some storage options, we are not always reading storage options from storage.conf. This can lead to some fields in the storage config (most notably extra storage options) being ignored, despite being set in storage.conf. Resolve this by unconditionally refreshing our storage config from storage.conf (this was previously only done for rootless Podman) Fixes containers#2217 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
mheon
force-pushed
the
force_storage_refresh
branch
from
e46c549 to
33845f8
Compare
|
LGTM Current version of the branch behaves as expected on my tests for both root and rootless containers. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our unconditionally setting some storage options, we are not always reading storage options from storage.conf. This can lead to some fields in the storage config (most notably extra storage options) being ignored, despite being set in storage.conf.
Resolve this by unconditionally refreshing our storage config from storage.conf (this was previously only done for rootless Podman)
Fixes #2217