Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman pod stats -- fix GO template output #2306

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

baude
Copy link
Member

@baude baude commented Feb 10, 2019

Go templates were not being processed or printed correctly for podman
pod stats. Added the ability to do templates as well as honor the
table identifier.

Fixes #2258

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Feb 10, 2019
cmd/podman/pod_stats.go Outdated Show resolved Hide resolved
Go templates were not being processed or printed correctly for podman
pod stats.  Added the ability to do templates as well as honor the
table identifier.

Fixes containers#2258

Signed-off-by: baude <bbaude@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2019

LGTM

@mheon
Copy link
Member

mheon commented Feb 11, 2019

I'm a bit concerned that we're adding tabwriter stuff back into the main code path, which could have the same perf implications that podman ps had that we needed a rewrite for.

On the other hand, I doubt we see as many pods as we did containers, so let's cross that bridge when we come to it.

/lgtm

@mheon
Copy link
Member

mheon commented Feb 11, 2019

Hey, bot, LGTM label please?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@baude
Copy link
Member Author

baude commented Feb 11, 2019

I'm a bit concerned that we're adding tabwriter stuff back into the main code path, which could have the same perf implications that podman ps had that we needed a rewrite for.

On the other hand, I doubt we see as many pods as we did containers, so let's cross that bridge when we come to it.

/lgtm

@mheon it wasnt tabwriter that had the perf implications, it was the use of the go templating for regular output and the multiple serializations needed for that.

@openshift-merge-robot openshift-merge-robot merged commit 8440b07 into containers:master Feb 11, 2019
@baude baude deleted the podstatsgotemplate branch December 22, 2019 19:02
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants