Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: logformatter: link to correct PR base #23081

Merged

Commits on Jun 25, 2024

  1. CI: logformatter: link to correct PR base

    Two enormous misunderstandings:
    
      1) $CIRRUS_BASE_SHA is worthless. I thought it was, you know,
         the BASE SHA of the current commit, but (as best I can tell)
         it seems to be the SHA of the most recent commit on the
         destination branch. Cirrus docs are unhelpful. Anyhow,
         it's clearly not anything useful. Stop using it.
    
      2) $EPOCH_TEST_COMMIT is closer to what we want. It is
         defined in Makefile as the git merge-base. But for unknown
         reasons it was being clobbered in CI scripts, and it
         doesn't seem to work in all contexts, so, eliminate it
         from CI setup scripts. Leave it only in Makefile.
    
    This leaves us with no option other than defining our own
    merge-base variable, PR_BASE_SHA. Do so and pass it along
    to rootless jobs.
    
    Signed-off-by: Ed Santiago <santiago@redhat.com>
    edsantiago committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1a6a200 View commit details
    Browse the repository at this point in the history