Add virtiofsd to rpm spec #23085
Add virtiofsd to rpm spec #23085
Conversation
With the merge of containers#22920, we now require virtiofsd on Linux for machine mounts. Signed-off-by: Brent Baude <bbaude@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
added
No New Tests
| @@ -93,6 +93,7 @@ BuildRequires: systemd | |||
| BuildRequires: systemd-devel | |||
| Requires: catatonit | |||
| Requires: conmon >= 2:2.1.7-2 | |||
| Requires: virtiofsd | |||
There was a problem hiding this comment.
Hmm, I thought we talked about a new podman-machine subpackage where this requirement could live (and we could add qemu there, or even in the future libvirt say)?
It's definitely not required to just run containers right now.
There was a problem hiding this comment.
Also, as long as we're touching the spec, we also must add a ln -sr /usr/libexec/virtiofs /usr/libexec/podman/ into it...which I think would be best done in that new "mostly metadata" subpackage.
There was a problem hiding this comment.
im not going to wait for that.
There was a problem hiding this comment.
Hmm...but are you sure you want to pull in virtiofsd everywhere today? It seems inconsistent as it's only a requirement for podman machine, but we don't also depend on qemu.
There was a problem hiding this comment.
IMO I don't think a requires on the podman package is right, it is not required for normal operation on linux, podman machine is some extra most users don't need which why I suggested creating a podman-machine package which holds the deps.
There was a problem hiding this comment.
@baude subpackage for podman-machine which only fetches the additional deps will probably cause the least pushback from other projects. machine users will explicitly need to dnf install podman-machine then.
There was a problem hiding this comment.
Set it up as recommends then or suggests. I don't think it is a big ideal if the package does not exists. But the podman machine commands will fail if it is not their by mistake. This means podman machine needs to be made smarter when qemu is not available.
There was a problem hiding this comment.
thats my point. either do you subpackage now or merge this. we dont have any releases going out so this is for dev only. @lsm5 if you do the subpackage, refer to this PR so i know to close it.
There was a problem hiding this comment.
Actually, because we look in $PATH for qemu, and after some debate due to the variations of virtiofsd's location on different OS/distros we ended up requiring a /usr/libexec/podman symlink...the status quo will just break podman machine users on these platforms unless they add that symlink into their packaging.
There was a problem hiding this comment.
@baude i have a draft PR at #23095
@cgwalters got a link to the symlink change please?
|
/ |
stale-locking-app
bot
added
the
locked - please file new issue/PR
With the merge of #22920, we now require virtiofsd on Linux for machine mounts.
Does this PR introduce a user-facing change?