Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Build-Each-Commit test: run only on PRs #23131

Merged
merged 1 commit into from
Jun 28, 2024
Merged

CI: Build-Each-Commit test: run only on PRs #23131

merged 1 commit into from
Jun 28, 2024

Conversation

edsantiago
Copy link
Member

Followup to #23081, which broke this test on nightly cron.

Signed-off-by: Ed Santiago santiago@redhat.com

None

@edsantiago
CI: Build-Each-Commit test: run only on PRs
c9e3458 
Followup to containers#23081, which broke this test on nightly cron.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago edsantiago requested a review from Luap99 June 28, 2024 12:00
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2024
Luap99
Luap99 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to only_if/skip this in cirrus.yml instead of spawning a task just to exit again. But looking at it there it is shared with the other cross builds so it is not straight forward and we would have to split the task out to define such a condition.

Given that LGTM in the interest of not adding more duplication in the yml, maybe starlark could help there as well?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Jun 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 045413b into containers:main Jun 28, 2024
88 checks passed
@edsantiago edsantiago deleted the build-each-commit-only-on-prs branch July 1, 2024 11:35
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 30, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@cevich cevich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edsantiago @cevich @Luap99