-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman auto-update/system df: fix ErrNoSuchCtr/Volume race #23305
Conversation
@edsantiago PTAL |
If a container is removed during the loop we should just ignore it. No reason to log this as error to the user. Fixes containers#23279 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
When a container or volume is removed during the loop this is not a problem and we should just skip it as it is not a user bug and just a normal race. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
/hold cancel |
LGTM. @containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ugh, just saw this in one of my laptop parallel runs (in the 610 test):
Any connection to this PR? |
no (I only touched container/volume code) the image query code is in libimage (c/common). It is is possible that it has a similar issue there |
If a container is removed during the loop we should just ignore it. No
reason to log this as error to the user.
Fixes #23279
Does this PR introduce a user-facing change?