-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: system tests: instrument to allow failure analysis #23378
Conversation
Two tests failing in gating but never CI; add some debug instrumentation to make it possible to find out what is going on Signed-off-by: Ed Santiago <santiago@redhat.com>
@lsm5 FYI. Too late for this round of gating tests, but when it fails again we'll be ready |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I always forget the "run" doesn't actually log anything by default...
I wonder if we should add a generic run_command wrapper like run_podman that we can use instead
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I submitted a PR years ago. They rejected it, but accepted some parts of it (automatic error checking) and I thought they were considering the logging parts. Looks like not. I've put this on my TODO list. |
Two tests failing in gating but never CI; add some debug
instrumentation to make it possible to find out what
is going on
Signed-off-by: Ed Santiago santiago@redhat.com