Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: system tests: instrument to allow failure analysis #23378

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

edsantiago
Copy link
Member

Two tests failing in gating but never CI; add some debug
instrumentation to make it possible to find out what
is going on

Signed-off-by: Ed Santiago santiago@redhat.com

None

Two tests failing in gating but never CI; add some debug
instrumentation to make it possible to find out what
is going on

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2024
@edsantiago
Copy link
Member Author

@lsm5 FYI. Too late for this round of gating tests, but when it fails again we'll be ready

@rhatdan
Copy link
Member

rhatdan commented Jul 23, 2024

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I always forget the "run" doesn't actually log anything by default...
I wonder if we should add a generic run_command wrapper like run_podman that we can use instead

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c804f10 into containers:main Jul 24, 2024
57 checks passed
@edsantiago edsantiago deleted the systest-fixes branch July 24, 2024 10:29
@edsantiago
Copy link
Member Author

I wonder if we should add a generic run_command wrapper like run_podman that we can use instead

I submitted a PR years ago. They rejected it, but accepted some parts of it (automatic error checking) and I thought they were considering the logging parts. Looks like not. I've put this on my TODO list.

@Luap99 Luap99 added the 5.2 label Jul 24, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 23, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.2 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants