-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert additional build context paths on Windows #23391
Conversation
LGTM |
Is this something we can test? |
I am going to add an e2e test. Converted it back to draft mode. |
LGTM |
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
I have added a new e2e machine test I have also updated Tests are green. I am switching this PR back to ready for review. |
@containers/podman-maintainers PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this mean Podman will now just work with Dev Containers? I can scarcely contain my excitement! |
A few clarifications:
"runArgs": [
"--userns=keep-id"
],
"containerEnv": {
"HOME": "/home/node"
} |
@l0rd thank you! |
This PR partially fixes issues with the option
--build-context <label>=<path>
ofpodman build
.This is enough to fix #17313 on macOS and Windows WSL with the default machine mounts.
A complete fix of the option
--build-context
would require packaging the additional build contexts in some additional tars and update the/libpod/build
endpoint to accept multi-part HTTP requests. But that's outside the scope of this PR.Does this PR introduce a user-facing change?