libpod: fix a confusing error message from 'podman system reset' on F… #24150
Conversation
…reeBSD This was discovered by a user while testing Podman on FreeBSD (oci-playground/freebsd-podman-testing/issues/17). The error message didn't stop 'podman system reset' from working and this commit simply suppressses the error on FreeBSD. Signed-off-by: Doug Rabson <dfr@rabson.org>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dfr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| func (r *Runtime) Migrate(newRuntime string) error { | ||
| return errors.New("not implemented (*Runtime) migrate") | ||
| } |
There was a problem hiding this comment.
should this actually be stubbed on freebsd?
This will cause podman system migrate to fail with this rather useless error as well,
besides the stopPauseProcess() call I do not see anything linux specific in there and with this change you NOP'ed that call so I would assume it would just work fine
|
@dfr ping still working on this? |
|
Sorry - I was busy with other things and then away on a trip. I will refresh this and take a look into |
…reeBSD
This was discovered by a user while testing Podman on FreeBSD (oci-playground/freebsd-podman-testing/issues/17). The error message didn't stop 'podman system reset' from working and this commit simply suppressses the error on FreeBSD.
Does this PR introduce a user-facing change?