-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cirrus: update CI images #24227
cirrus: update CI images #24227
Conversation
Images from containers/automation_images#387 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
LGTM |
Something is broken on debian, it seems it is missing certain timezones now? |
From the debian changelog:
I guess I update the test here then and hope this is enough as this might hit fedora sooner or later too. |
3a8dfca
to
ee70c49
Compare
@edsantiago PTAL |
f444971
to
6a1e184
Compare
In debian EST and MST7MDT are gone by default and moved to a special package[1], instead of also installing that in the images lets use different timezones in the test. [1] https://salsa.debian.org/glibc-team/tzdata/-/commit/42c0008f86a5a53e1a37fefa93fdd3685313e86f Signed-off-by: Paul Holzinger <pholzing@redhat.com>
They no longer work in the latest image update, it is not clear why and I do not have the time to debug that stuff. I opened containers#24230 to track it. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
6a1e184
to
4e3a037
Compare
"Adding fedoraproject.org to the local registry cache is too hard right now," he said. "We can worry about it some other day." Sigh. |
This seems unexpected, we should not resolve the short name there I think as this is a a custom image build there. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
I think shortname resolution is expected in this test: _write_test_yaml command=id image=$userimage <<< if we didn't want shortname resolution, this would be qualified
run_podman 125 play kube --build --start=false $TESTYAML
assert "$output" "=~" \
"Error: short-name resolution enforced but cannot prompt without a TTY|Resolving \"$userimage\" using unqualified-search registries" \
"The error message does match any of the expected ones" I will wipe this off my worry list unless/until I hear otherwise. |
If it causes flakes then it is a concern. Maybe not bad enough to fix immediately but I will start documenting them in https://issues.redhat.com/browse/RUN-2202 so we know what needs to be addressed to remove such network flakes in the future. |
Images from containers/automation_images#387
Does this PR introduce a user-facing change?