Mention containers.conf settings for podman machine commands #24242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Oct 14, 2024
| @@ -52,6 +52,8 @@ Fedora CoreOS upgrades come out every 14 days and are detected and installed aut | |||
| For more information on updates and advanced configuration, | |||
| see the Fedora CoreOS documentation about [auto-updates](https://docs.fedoraproject.org/en-US/fedora-coreos/auto-updates/) and [update strategies](https://coreos.github.io/zincati/usage/updates-strategy/). | |||
|
|
|||
| Default podman machines settings can set via the [machine] section in the containers.conf(5) file. | |||
There was a problem hiding this comment.
Suggested change
| Default podman machines settings can set via the [machine] section in the containers.conf(5) file. | |
| Default podman machines settings can be set via the [machine] section in the containers.conf(5) file. |
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Cockpit tests failed for commit 3a4c446. @martinpitt, @jelly, @mvollmer please check. |
|
LGTM |
|
cockpit f41 test failure is the same "occasional criu failure" than in #24238 (comment) . It ran before the improved debugging cockpit-project/cockpit-podman#1878 , so this is useless, and can be ignored or retried here. I.e. all good from our side. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 40dae5e
into
containers:main
38 of 39 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?