Housekeeping: remove duplicates from success_task

[edsantiago]

Accidentally introduced in #21639.

There's probably a way to check for dups in cirrus_yaml_test.py
but my python is too rusty.

Signed-off-by: Ed Santiago santiago@redhat.com

None

[baude]

LGTM

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[Luap99]

diff --git a/contrib/cirrus/cirrus_yaml_test.py b/contrib/cirrus/cirrus_yaml_test.py
index f127ffbfa2..b19dd111ca 100755
--- a/contrib/cirrus/cirrus_yaml_test.py
+++ b/contrib/cirrus/cirrus_yaml_test.py
@@ -60,6 +60,18 @@ class TestDependsOn(TestCaseBase):
                 msg=('No success aggregation task depends_on "{0}"'.format(task_name))
                 self.assertIn(task_name, success_deps, msg=msg)
 
+    def test_duplicate_depends(self):
+        """Check for duplicate names in depends_on"""
+        for task_name in self.ALL_TASK_NAMES:
+            task = self.CIRRUS_YAML[task_name + '_task']
+            if 'depends_on' in task:
+                depends_on = task['depends_on']
+                seen = set()
+                for x in depends_on:
+                    self.assertNotIn(x,seen, msg=f"depends_on contains duplicated names in task {task_name}")
+                    seen.add(x)
+
+
     def test_only_if(self):
         """2024-07 PR#23174: ugly but necessary duplication in only_if conditions. Prevent typos or unwanted changes."""
         # N/B: This giant string is white space sensitive, take care when updating/modifying

Some quick 5min from me, results in this one main:

FAIL: test_duplicate_depends (__main__.TestDependsOn.test_duplicate_depends)
Check for duplicate names in depends_on
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pholzing/go/src/github.com/containers/podman/./contrib/cirrus/cirrus_yaml_test.py", line 71, in test_duplicate_depends
    self.assertNotIn(x,seen, msg=f"depends_on contains duplicated names in task {task_name}")
AssertionError: 'local_system_test' unexpectedly found in {'rootless_system_test', 'podman_machine_mac', 'rootless_integration_test', 'unit_test', 'podman_machine_windows', 'local_system_test', 'local_system_test_aarch64', 'swagger', 'bindings', 'remote_system_test_aarch64', 'remote_system_test', 'apiv2_test', 'rootless_remote_system_test', 'compose_test', 'local_integration_test', 'container_integration_test', 'podman_machine', 'docker-py_test', 'build_success', 'podman_machine_aarch64', 'win_installer', 'remote_integration_test'} : depends_on contains duplicated names in task success

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment