On Windows avoid installing WSL during an update of Podman #24624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows installer GUI has a checkbox to choose if WSL and HyperV should be installed as part of the installation of Podman. Now, by default, that checkbox is disabled for both WSL and HyperV. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
The condition `NOT Installed` had not effect and has been replaced with `NOT WIX_UPGRADE_DETECTED` that is `true` during installation and `false` during updates. The `ExePackage` WSL Kernel Install is also not installed if Podman is already present. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
The windows installer tests are command line / non interactive. To test as much as possible the GUI / interactive scenario (that is what user do), update tests need to use the installer with the default options. That's because when using the GUI for an update, changing options is not possible. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
l0rd
changed the title
l0rd
changed the title
|
Tests are green, @containers/podman-maintainers PTAL |
|
LGTM |
|
@mheon: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@mheon: new pull request created: #24627 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
l0rd
added a commit
to l0rd/podman
that referenced
this pull request
Feb 5, 2025
The Windows installer was able to automatically enable the Windows features for WSL or HyperV when they were not already enabled. This PR removes this capability. Having the installer to automatically install the right prerequiste (WSL or HyperV) was helpful as users won't have to do it manually to use Podman after the installation. But it also made the code of installer more complicated as it needed to manage the installation of these OS features and a reboot. And we weren't able to automatically test these scenarios that required a reboot. In other words the Windows installer, that merely just extracted some files in a folder, required, to support the installation of WSL and HyperV, an advanced knowledge of WiX toolkit and of the Windows Installer SDK, plus contributors-time to manually test the scenarios that require a reboot. We decided to remove this capability based on the following reasons: - We had a couple of regressions in the last month that were hard to analyse and fix (containers#24624 and containers#24735) - Podman maintainers currently have a scarce knowledge of the Windows Installer and there is no plan to invest in that - Manually installing WSL or HyperV is not hard (e.g. run `wsl --install`) and are features that admins can manage on their fleet of Windows machines - Competitors such as Docker Desktop don't automatically install these components - Podman `machine init` currently verifies if WSL and HyperV are installed and guide the user to install them when they are not Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
added a commit
to l0rd/podman
that referenced
this pull request
Feb 5, 2025
The Windows installer was able to automatically enable the Windows features for WSL or HyperV when they were not already enabled. This PR removes this capability. Having the installer to automatically install the right prerequiste (WSL or HyperV) was helpful as users won't have to do it manually to use Podman after the installation. But it also made the code of installer more complicated as it needed to manage the installation of these OS features and a reboot. And we weren't able to automatically test these scenarios that required a reboot. In other words the Windows installer, that merely just extracted some files in a folder, required, to support the installation of WSL and HyperV, an advanced knowledge of WiX toolkit and of the Windows Installer SDK, plus contributors-time to manually test the scenarios that require a reboot. We decided to remove this capability based on the following reasons: - We had a couple of regressions in the last month that were hard to analyse and fix (containers#24624 and containers#24735) - Podman maintainers currently have a scarce knowledge of the Windows Installer and there is no plan to invest in that - Manually installing WSL or HyperV is not hard (e.g. run `wsl --install`) and are features that admins can manage on their fleet of Windows machines - Competitors such as Docker Desktop don't automatically install these components - Podman `machine init` currently verifies if WSL and HyperV are installed and guide the user to install them when they are not Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A condition to automatically install the provider (WSL or Hyper-V) was
NOT Installed(c.f. the Windows installerInstalledproperty). But that condition is evaluated astrueeven during an update, and, as a consequence, the provider could be installed during an update, too. Something that we want to avoid. To fix this behavior, we are now using the conditionNOT WIX_UPGRADE_DETECTEDinstead.In the PR, we have also updated the Windows installer (CLI) tests to execute the update using the default installation options (to match the Windows installer GUI scenario).
Another change introduced by this PR is the default value of the "Install WSLv2 if not present" checkbox. It's now unchecked by default (as was the case for the "Install Hyper-V if not present" checkbox).
Does this PR introduce a user-facing change?