Kube volumes can not contain _ #24868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to substiture all _ to - for k8s support. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
openshift-ci
bot
added
release-note-none
approved
rhatdan
changed the title
giuseppe
approved these changes
Dec 19, 2024
Comment on lines
+1265
to
+1273
| func fixKubeVolumeName(source string) string { | ||
| // Trim trailing slashes, | ||
| // Replace slashes with dashes. | ||
| // Replace underscores with dashes. | ||
| // Force all letters to lower case | ||
| // Thus, /mnt/data/ will become mnt-data | ||
| return strings.ToLower(strings.ReplaceAll(strings.ReplaceAll(strings.Trim(source, "/"), "/", "-"), "_", "-")) | ||
| } | ||
|
|
There was a problem hiding this comment.
this is the perfect candidate for a unit test.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to substiture all _ to - for k8s support.
Does this PR introduce a user-facing change?