pkg/systemd: expose [Pod] ExitPolicy key for pod create --exit-policy

[nbspsemicolon]

Add ExitPolicy key to pod quadlets with logic to default to stop.

Docs updated with clarifcation on default value and usage example.

Simple assert added to bats to verify default constraint exists.

Addresses #25596

See Also: #26453

Does this PR introduce a user-facing change?

Added ExitPolicy for [Pod] in systemd quadlets

[nbspsemicolon]

DCO is wrong. Signed-off-by is in the commit message.

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[Luap99]

Commit sha: 06db239, Author: nbspsemicolon, Committer: nbspsemicolon; Expected "nbspsemicolon nbsp@nbailey.net", but got "Neil Bailey nbsp@nbailey.net".

The reason DCO check complains is because you git username (git config user.name) is not set to the real name used to sign off. That is not a blocker and I can set it to manual pass if wanted. Otherwise you can fix it with something like
git commit --amend --author="Neil Bailey nbsp@nbailey.net"

[Luap99]

Tests are failing because the argument order between --exit-policy=stop and --replace is swapped now. That is fine as it works in the same way but you will have to update the basic.pod test to make them pass.

cc @ygalblum

[ygalblum]

LGTM for the code.
As @Luap99 wrote, basic.pod need to be adjusted.

[ygalblum]

Please add an extra empty line

[ygalblum]

Should we add a section to the man page explaining the usage of --exit-policy?

[nbspsemicolon]

Looks like I accidentally added a file while trying to fix the test. I'll squash again with the newline in docs added.

[baude]

no biggie but if one of these options is kind of a default, we will often set that and use a single condition as an override. maybe consider fix if you repush with someone else's comment (only if you consider one of them to be the default).

[nbspsemicolon]

I'm not sure what to make of the debian and rawhide tests.

[Luap99]

/lgtm

I restart the test it is a known flake

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, nbspsemicolon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment