test/e2e: fix "with unsafe hostPath subpaths" test #26490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent pasta update changed the selinux rules and we now run pasta under pasta_t and no longer the container_runtime_t type. The pasta type has much stricter type rules on what the file we hand it must be labelled. This test tries to mount the runroot which gets relabeled with the container_file_t type but that means pasta can no longer access its pid file we give it. To fix this test here simply mount a subdir. see containers#26473 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
cc @timcoding1988 This will fix the test problem found in #26341 |
openshift-ci
bot
added
the
approved
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
timcoding1988
requested review from
timcoding1988
and removed request for
timcoding1988
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit 72e8c82
into
containers:main
52 of 53 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent pasta update changed the selinux rules and we now run pasta under pasta_t and no longer the container_runtime_t type. The pasta type has much stricter type rules on what the file we hand it must be labelled. This test tries to mount the runroot which gets relabeled with the container_file_t type but that means pasta can no longer access its pid file we give it. To fix this test here simply mount a subdir.
see #26473
Does this PR introduce a user-facing change?