Fix a potential segfault in podman search #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
mheon
force-pushed
the
prevent_null_deref
branch
from
e4d3450 to
9f14ec5
Compare
|
bot, retest this please |
mheon
force-pushed
the
prevent_null_deref
branch
from
9f14ec5 to
60aed1f
Compare
|
☔ The latest upstream changes (presumably #2620) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
|
@mheon Needs a rebase. |
mheon
force-pushed
the
prevent_null_deref
branch
from
60aed1f to
e944def
Compare
openshift-ci-robot
removed
the
needs-rebase
|
Rebased, should be good to merge now |
|
/lgtm |
|
/retest |
|
@mheon This might need a new rebase? |
mheon
force-pushed
the
prevent_null_deref
branch
from
e944def to
328b2ac
Compare
|
Rebased again |
|
Seems to be failing on search. |
When generating headers for search, we unconditionally access element 0 of an array, and I saw this segfault in our CI. There's no reason we have to do this, we're just going through it to get field names with reflect, so just make a new copy of the struct in question. Also, move this code, which is only for CLI display, into cmd/podman from libpod/image. Signed-off-by: Matthew Heon <mheon@redhat.com>
mheon
force-pushed
the
prevent_null_deref
branch
from
328b2ac to
c625553
Compare
|
Alright, let's see... This ought to fix it |
|
Yep, tests good |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating headers for search, we unconditionally access element 0 of an array, and I saw this segfault in our CI. There's no reason we have to do this, we're just going through it to get field names with reflect, so just make a new copy of the struct in question.
Also, move this code, which is only for CLI display, into cmd/podman from libpod/image.