Skip to content

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Aug 19, 2025

In the journald driver there is a bug where the network event attributes are not preserved. This causes the network driver to be missing and that in turn causes the ToHumanReadable() function to print an empty line. Fix it by making sure we preserve the network driver in the event attributes.

Fixes: https://issues.redhat.com/browse/RHEL-109790

Does this PR introduce a user-facing change?

Correctly display the network create/remove events when using the journald event driver.

In the journald driver there is a bug where the network event
attributes are not preserved. This causes the network driver to be
missing and that in turn causes the ToHumanReadable() function to print
an empty line. Fix it by making sure we preserve the network driver in
the event attributes.

Fixes: https://issues.redhat.com/browse/RHEL-109790

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@mheon
Copy link
Member

mheon commented Aug 19, 2025

/cherry-pick v5.6

@openshift-cherrypick-robot
Copy link
Collaborator

@mheon: once the present PR merges, I will cherry-pick it on top of v5.6 in a new PR and assign it to you.

In response to this:

/cherry-pick v5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@baude
Copy link
Member

baude commented Aug 19, 2025

LGTM

@mheon
Copy link
Member

mheon commented Aug 19, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bb18ae6 into containers:main Aug 19, 2025
79 of 81 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@mheon: new pull request created: #26863

In response to this:

/cherry-pick v5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants