-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Podman 6 HLD #27043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Podman 6 HLD #27043
Conversation
|
i did this from a google doc export but it makes paragraphs one per line. Do folks think i should employ line breaks at say 100 chars or so ? |
|
I usually do a line break every sentence, but 100 chars also works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I agree more line breaks would be nice but that should not matter when viewing in the rendered form so I don't care much.
contrib/design-docs/podman6hld.md
Outdated
|
|
||
| ## **Slirp4netns** | ||
|
|
||
| [Slipr4netns](https://github.com/rootless-containers/slirp4netns) was the original network utility for rootless Podman and has been replaced by [Pasta](https://passt.top/passt/about/). Podman has been able to use Pasta since version 4.4. In Podman 5.0, Pasta became the default rootless option and a deprecation notice for slirp4netns was made in Podman 5\. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a deprecation notice for slirp4netns was made in Podman 5
The text looks good but I'm curious where to find the deprecation notice. I searched in https://github.com/containers/podman/blob/main/RELEASE_NOTES.md
but couldn't find it. I also did some recursive grep
grep -ri slirp4netns docs/
grep -ri deprecat docs/
Maybe I just missed it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if it got wacked between 4 and 5? @mheon are you aware ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to go looking. It might have just gone out in a blog post, which could be an issue. We can include a formal reminder in the 5.7 release notes, which still gives 6 months notice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can include a formal reminder in the 5.7 release notes, which still gives 6 months notice?
sgtm
|
We should merge this and the Conmonv3 doc this week, we've given plenty of time for review |
Adding a design document for Podman 6. it is a high level design that tries to encompasses proposed changes to Podman and its runtime environment. It should highlight major changes and features; but you will also find nitty detailed changes that have been idenitified. It is quite possible things in this document will change but it allows for open, transparent communication. Signed-off-by: Brent Baude <bbaude@redhat.com>
|
updated with comment fixes and added line breaks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a118fdf
into
containers:main
Adding a design document for Podman 6. it is a high level design that tries to encompasses proposed changes to Podman and its runtime environment. It should highlight major changes and features; but you will also find nitty detailed changes that have been idenitified. It is quite possible things in this document will change but it allows for open, transparent communication.
Does this PR introduce a user-facing change?