Skip to content

Conversation

@samifruit514
Copy link

Does this PR introduce a user-facing change?

Added `-100` message parsing (healthchecks) from `conmon`'s unix pipe. 

Depends on conmon's PR suggested: containers/conmon#599

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: samifruit514
Once this PR has been reviewed and has the lgtm label, please assign tomsweeneyredhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samifruit514 samifruit514 marked this pull request as draft September 13, 2025 23:37
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2025
Signed-off-by: Samuel Archambault <samuel.archambault@getmaintainx.com>
@samifruit514 samifruit514 force-pushed the healthcheck-from-conmon branch from c57d909 to a2be1d8 Compare October 7, 2025 00:01
Samuel Archambault added 2 commits October 12, 2025 11:05
…ystemd builds

These changes added healthcheck configuration as JSON annotations to the OCI spec,
but non-systemd builds use CLI arguments instead of OCI annotations for
healthcheck configuration.
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant