lint: reenable revive unused-parameter check

[medsouz]

To help maintain the sanity of whoever has to review this PR I've limited my changes to only change argument names violating this linter to _. There seems to be a few spots that could be cleaned up further but that feels out of scope for a change this large.

Resolves #27111

Does this PR introduce a user-facing change?

None

[medsouz]

Looks like there are still some changes needed to environments other than Linux. Once CI is complete I'll address these.

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

[Honny1]

Thanks, LGTM. Just one small request: could you please squash all your commits into one?

CI fails are flakes.

[Honny1]

Thanks, LGTM.

/LGTM

[Luap99]

Thank you LGTM, looks like it needs a rebase though

[medsouz]

Should be good for review now. Thanks for taking a look at this

[Luap99]

/lgtm

Thanks

[Honny1]

/LGTM

To get this merged, please retrigger the CI. The test looks like it's flaking—otherwise LGTM.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, medsouz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@medsouz looks like there is yet another merge conflict so you have to rebase again.

I try to to get this merged quickly once you push again so you hopefully don't have to deal with that again, sorry about that.

[medsouz]

No worries @Luap99, merging something that touches this many files is always a pain. 😆

Should be good to go now but I'll keep an eye on CI and any future merges to main today to keep it in a ready state.

[Luap99]

/lgtm