Skip to content

cmd: add autocomplete for network create --interface-name flag #27132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

cmd: add autocomplete for network create --interface-name flag #27132

merged 1 commit into from
Sep 30, 2025

Conversation

NotSoFancyName
Copy link
Contributor

Does this PR introduce a user-facing change?

Implements requested feature #27113 which adds the autocomplete for podman network create --interface-name flag

Added autocomplete for network create --interface-name flag

@NotSoFancyName
Copy link
Contributor Author

NotSoFancyName commented Sep 20, 2025 •
edited
Loading

I am aware that any change requires tests to be added, but I am not sure where I could add one (and if I even should). I have checked the 600-completion.bats and the completion unit tests, and I did not have an idea how I could add one for checking the interface completion.

@NotSoFancyName NotSoFancyName force-pushed the interface-completion branch 6 times, most recently from a8f6924 to 18c2265 Compare September 24, 2025 21:03
@TomSweeneyRedHat
Copy link
Member

Changes LGTM
@Luap99 ? Any concerns with the autocomplete here?

Honny1
Honny1 reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Luap99
Luap99 reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the chnage itself LGTM.
You have a merge conflict so you need to rebase and fix it, and if you do so please also add Fixes: #27113 to the commit message so the issues is correctly linked and getws closed on merge.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
Luap99
Luap99 reviewed Sep 30, 2025
View reviewed changes
test/system/600-completion.bats
assert "$output" =~ "^net\." \
"Only suggestions with 'net.' should be present for podman run --sysctl net."

@test "podman network create --interface-name" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict was not resolved correctly you are missing this on the test above:

    _check_completion_end NoFileComp
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, it happens to all of us

@NotSoFancyName
cmd: add auto completion for network create --interface-name
ebde5d1 
Fixes: containers#27113

Signed-off-by: Volodymyr Pankin <volopank@gmail.com>
Luap99
Luap99 approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, NotSoFancyName

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0742349 into containers:main Sep 30, 2025
66 of 81 checks passed
@NotSoFancyName NotSoFancyName deleted the interface-completion branch October 7, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Luap99 Luap99 Luap99 approved these changes

+1 more reviewer

@Honny1 Honny1 Honny1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NotSoFancyName @TomSweeneyRedHat @Honny1 @Luap99 @openshift-merge-robot