cmd/podman/system: fix error handling in renumber and migrate commands #27178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change function signatures to return error instead of calling os.Exit() - Update cobra commands to use RunE instead of Run for proper error handling - Remove unused imports (fmt, os, define) - Remove FIXME comments about error handling inconsistency This allows defer statements to run properly and improves testability. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
openshift-ci
bot
added
do-not-merge/release-note-label-needed
Honny1
added
the
No New Tests
Honny1
reviewed
Sep 29, 2025
There was a problem hiding this comment.
Thanks, LGTM. I've added the No New Tests label, so let's see if the CI passes. Could you please retrigger this CI job? https://cirrus-ci.com/task/6034581192704000
/LGTM
|
Thanks @Honny1, I just re-triggered it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, osamakader The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows defer statements to run properly and improves testability.
Does this PR introduce a user-facing change?