Skip to content

test: fix "run healthcheck" bindings test #27195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

test: fix "run healthcheck" bindings test #27195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions pkg/bindings/test/containers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,22 +330,9 @@ var _ = Describe("Podman containers ", func() {
code, _ = bindings.CheckResponseCode(err)
Expect(code).To(BeNumerically("==", http.StatusConflict))

// TODO for the life of me, i cannot get this to work. maybe another set
// of eyes will
// successful healthcheck
// status := define.HealthCheckHealthy
// for i:=0; i < 10; i++ {
// result, err := containers.RunHealthCheck(connText, "hc")
// Expect(err).To(BeNil())
// if result.Status != define.HealthCheckHealthy {
// fmt.Println("Healthcheck container still starting, retrying in 1 second")
// time.Sleep(1 * time.Second)
// continue
// }
// status = result.Status
// break
// }
// Expect(status).To(Equal(define.HealthCheckHealthy))
result, err := containers.RunHealthCheck(bt.conn, "hc", nil)
Expect(err).ToNot(HaveOccurred())
Expect(result.Status).To(Equal(define.HealthCheckHealthy))

// TODO enable this when wait is working
// healthcheck on a stopped container should be a 409
Expand Down