Skip to content

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Oct 3, 2025

Wait for killed container ignoring exit status to avoid leak.

We see this sporadic failure a lot in the rootless/remote scenario:

https://openqa.opensuse.org/tests/5359148/file/podman-bats-user-remote.tap.txt

#not ok 302 [130] podman kill - print IDs or raw input # in 864 ms
# (from function `basic_teardown' in file test/system/helpers.bash, line 255,
#  from function `teardown' in test file test/system/helpers.bash, line 265)
#   `basic_teardown' failed
# 
# [23:46:42.104180370] $ /usr/bin/podman-remote run --rm -d quay.io/libpod/testimage:20241011 top
# [23:46:42.272297627] 547df43df0e9ce0132e19f3073a6268e4734132b3c742ef66cec9ce8519a4fb5
# 
# [23:46:42.278042528] $ /usr/bin/podman-remote kill -a
# [23:46:42.351655661] 547df43df0e9ce0132e19f3073a6268e4734132b3c742ef66cec9ce8519a4fb5
# 
# [23:46:42.371353512] $ /usr/bin/podman-remote run --rm -d --name c-t302-pmmcj57o quay.io/libpod/testimage:20241011 top
# [23:46:42.533612827] def040d84cb3a752616e01d72c7dbf358623f65241ce7221218f21685a584fdc
# 
# [23:46:42.538995022] $ /usr/bin/podman-remote kill c-t302-pmmcj57o
# [23:46:42.618828613] c-t302-pmmcj57o
# # [teardown]
# vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# *** Leaked container: def040d84cb3 quay.io/libpod/testimage:20241011 c-t302-pmmcj57o  Removing

Does this PR introduce a user-facing change?

None

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

The failed CI test looks like a flake. Please retrigger it here: https://cirrus-ci.com/task/6278296695996416. As the PR author, you have permission to do so.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@baude
Copy link
Member

baude commented Oct 3, 2025

LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, ricardobranco777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a0992f7 into containers:main Oct 3, 2025
55 checks passed
@ricardobranco777 ricardobranco777 deleted the fix/130-kill branch October 3, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants