Skip to content

test/system: two small fixes #27233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

test/system: two small fixes #27233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb5ac5
test/system: run_podman ? needs quoting
Luap99 Oct 6, 2025
3e774ee
test/system: actually wait for container removal
Luap99 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/system/030-run.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,7 +1638,7 @@ search | $IMAGE |
"$command --authfile=nonexistent-path"

if [[ "$command" != "logout" ]]; then
REGISTRY_AUTH_FILE=$bogus run_podman ? $command $args
REGISTRY_AUTH_FILE=$bogus run_podman '?' $command $args
assert "$output" !~ "credential file is not accessible" \
"$command REGISTRY_AUTH_FILE=nonexistent-path"

Expand Down
4 changes: 3 additions & 1 deletion test/system/130-kill.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ load helpers
run_podman run --rm -d --name $cname $IMAGE top
run_podman kill $cname
is "$output" $cname
run_podman ? wait $cname
# Wait for the container to get removed to avoid the leak check from triggering,
# since it might have already been removed here ignore the exit code check.
run_podman '?' wait --condition=removing $cname
}

# bats test_tags=ci:parallel
Expand Down