Fix remote client rejecting empty --detach-keys string

[shiavm006]

Problem

The remote client (podman --remote) incorrectly throws an error when --detach-keys="" is specified:

Error: invalid detach keys: Unknown character: ''

According to the documentation (docs/source/markdown/options/detach-keys.md):

Specifying "" disables this feature
The local client handles this correctly and was fixed in v1.7.0 (issue #5166), but the remote client was missed.

The remote client bindings call term.ToBytes() directly on the user-provided string, which fails for empty strings. The local implementation checks for empty string first before calling term.ToBytes().

Solution

Added the same empty string check in pkg/bindings/containers/attach.go that exists in the local code path (libpod/oci_conmon_attach_common.go:199):

if options.GetDetachKeys() == "" {
    detachKeysInBytes = []byte{}
} else {
    detachKeysInBytes, err = term.ToBytes(options.GetDetachKeys())
    // ...
}

Fixes: #27414

'None'

[mheon]

/approve
LGTM

[Luap99]

Thanks, can you squash your commits please into one and add Fixes: #27414 as part of the commit message to properly cross link the issue and have it closed on merge.

[Honny1]

Thanks, LGTM.

[zhangguanzhang]

need to rebase:

git rebase -i HEAD~2 

[shiavm006]

Thanks, can you squash your commits please into one and add Fixes: #27414 as part of the commit message to properly cross link the issue and have it closed on merge.

thanks i missed that done.

[Honny1]

LGTM

I am rerunning flaky tests.

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, mheon, shiavm006

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Honny1,Luap99,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment