storage: support --mount type=bind,bind-nonrecursive #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
There was a problem hiding this comment.
couple doc nits, otherwise LGTM. Good candidate for the next release @mheon.
|
@giuseppe looks like you might have some test issues. |
giuseppe
force-pushed
the
support-bind-nonrecursive
branch
4 times, most recently
from
35f7b0d to
704ac6f
Compare
mheon
reviewed
Jun 13, 2019
|
One nit otherwise LGTM |
add support for not recursive bind mounts. Closes: containers#3314 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-bind-nonrecursive
branch
from
704ac6f to
23efe4c
Compare
|
tests are green |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for not recursive bind mounts.
Closes: #3314
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com