-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpod: discerne partial IDs between containers and pods #3488
Conversation
When specifying a podman command with a partial ID, container and pod commands matches respectively only containers or pods IDs in the BoltDB. Fixes: containers#3487 Signed-off-by: Marco Vedovati <mvedovati@suse.com>
Hi @marcov. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch?
|
bot, add author to whitelist |
I believe the test issues are unrelated CI issues that @mheon has been fighting with. |
Hm. I like this... actually ends up simplifying the code paths. |
/approve |
lgtm but this isnt my area of expertise ... @mheon defer to you |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marcov, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(Probably also a bit more performant for searches... less things to iterate through) |
Merging |
When specifying a podman command with a partial ID, container and pod
commands matches respectively only containers or pods IDs in the BoltDB.
Fixes: #3487
Signed-off-by: Marco Vedovati mvedovati@suse.com