Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpod: fix stats for rootless pods #4639

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Dec 4, 2019

honor the systemd parent directory when specified.

also enable all the stats tests for rootless on cgroups v2.

Closes: #4634

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

honor the systemd parent directory when specified.

Closes: containers#4634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Dec 4, 2019
@giuseppe giuseppe force-pushed the fix-stats-pod branch 2 times, most recently from bd0aa0e to 29393df Compare December 4, 2019 11:49
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@mheon
Copy link
Member

mheon commented Dec 4, 2019

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons.

@rhatdan
Copy link
Member

rhatdan commented Dec 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4fb724c into containers:master Dec 5, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman pod stats fails in rootless mode
6 participants