Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libpod.conf man page (closes #537) #641

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

nathwill
Copy link
Contributor

saw this todo open, thought i'd take a whack at it. anything i should add (e.g. SEE ALSO section, or...)?

% Nathan Williams
% APRIL 2018

## NAME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add default path.

@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2018

You will have to fix the Makefile to install into man5 as well as man1. Probably want to rename all of the existing man pages to 1.md files.

@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2018

Also need to update the spec file in contrib/spec/podman.spec.in

@mheon
Copy link
Member

mheon commented Apr 19, 2018

@nathwill Missing a signoff on the commit, can you sign with -s and force-push?

Signed-off-by: Nathan Williams <nath.e.will@gmail.com>
@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2018

LGTM
@mheon @umohnani8 @baude @TomSweeneyRedHat PTAL

@mheon
Copy link
Member

mheon commented Apr 24, 2018

LGTM
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 79f08c4 has been approved by mheon

@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2018

HOMU seems to be hung.

@rhatdan rhatdan merged commit c78ce0e into containers:master Apr 24, 2018
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants