system df: fix image-size calculations #7604
Conversation
Fix the image-size calculations of system-df, where the shared size is the actual shared size with other images (including children) and the (total) size is the sum of the shared and unique size [1]. To calculate parent/child relations, make use of the recently added layer tree which allows for quick (and cached!) calculations. Break calculating image disk usages into the image runtime to a) access the layer tree, and b) make the code easier to maintain and extend. [1] https://docs.docker.com/engine/reference/commandline/system_df/ Fixes: containers#7406 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@rhatdan PTAL |
|
Awesome work @vrothberg |
|
LGTM, but tests are going red |
|
May have just been a flake, restarting |
| stat.SharedSize = *size | ||
| } | ||
|
|
||
| stat.Size = stat.SharedSize + stat.UniqueSize |
There was a problem hiding this comment.
stat.Size can directly set to size after L99
There was a problem hiding this comment.
but this follows the definition in the documentation
There was a problem hiding this comment.
Thanks for checking! Yes, I wanted to make it more obvious that Size is the sum of the other two.
|
LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Fix the image-size calculations of system-df, where the shared size is
the actual shared size with other images (including children) and the
(total) size is the sum of the shared and unique size [1].
To calculate parent/child relations, make use of the recently added
layer tree which allows for quick (and cached!) calculations.
Break calculating image disk usages into the image runtime to a) access
the layer tree, and b) make the code easier to maintain and extend.
[1] https://docs.docker.com/engine/reference/commandline/system_df/
Fixes: #7406
Signed-off-by: Valentin Rothberg rothberg@redhat.com