Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image list: ignore bare manifest list #8934

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Jan 11, 2021

Handle empty/bare manifest lists when listing images.

Fixes: #8931
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg vrothberg force-pushed the fix-8931 branch 2 times, most recently from c40f40d to b5f3355 Compare January 11, 2021 12:00
@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@mheon
Copy link
Member

mheon commented Jan 11, 2021

Your new system test is failing

@vrothberg
Copy link
Member Author

I begin to believe that the image should be listed.

Handle empty/bare manifest lists when listing images.

Fixes: containers#8931
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@vrothberg
Copy link
Member Author

Changed to list the empty manifest list. @mheon @rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit a651089 into containers:master Jan 11, 2021
@vrothberg vrothberg deleted the fix-8931 branch March 12, 2021 12:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildah manifest list breaks podman image listing
6 participants