Report StatusConflict on Pod opt partial failures

[jwhonce]

• When one or more containers in the Pod reports an error on an operation
  report StatusConflict and report the error(s)

• jsoniter.RegisterTypeEncoderFunc() used to marshal error as string using error.Error(). This picks up any other places in API where error has been used.

• Update test framework to allow setting any flag when creating pods

Fixes #8865

Signed-off-by: Jhon Honce jhonce@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

code and idea LGTM, legit test failures

[vrothberg]

Code LGTM but I don't have enough knowledge judging whether 409 Conflict is valid in all cases.

MDN states: "Conflicts are most likely to occur in response to a PUT request. For example, you may get a 409 response when uploading a file which is older than the one already on the server resulting in a version control conflict."

Does that include transient errors of pod start?

[jwhonce]

@vrothberg The handler already used 409, I simply documented that fact and expanded it's usage to all instances of this condition. I believe 409 is more useful than 500 (that was returned in some cases) since a retry may resolve the issue, which is not implied by 500.

[mheon]

/lgtm