Add powershell completions

[Luap99]

Add support for generating powershell completion files. This is especially
useful for people using the podman remote client on windows.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jwhonce]

@Luap99 LGTM, you have some formatting issues.

[edsantiago]

I can't really review this: I've never actually used MS Windows. I have no way to know if this will work, or to verify your Get-Help or other man page instructions.

I found one super-minor typo, and have one question for the team at large.

I did confirm your Makefile changes, and did consistency checks on man pages. All looks good.

One question: the .ps1 files you're submitting seem to have been generated with this version of cobra:

$ ./bin/podman completion powershell|diff -u - completions/powershell/podman.ps1
[no output, exit status 0]

The other completion files are generated using cobra with various unmerged patches (sorry, I can't keep track of the precise details). My understanding is that the .ps1 files aren't used at all, but if someone Windows-savvy figures out how to distribute them, would it be useful for you to submit .ps1 files including your custom cobra changes?

[edsantiago]

This tentatively LGTM, and seems to be consistent with other uses of Base in the code, but it's the sort of change I'd like a lot of eyeballs on. @containers/podman-maintainers PTAL.

[Luap99]

This is important for windows since the path package splits only on a regular slash even on windows.

[Luap99]

The other completion files are generated using cobra with various unmerged patches (sorry, I can't keep track of the precise details). My understanding is that the .ps1 files aren't used at all, but if someone Windows-savvy figures out how to distribute them, would it be useful for you to submit .ps1 files including your custom cobra changes?

I implemented the powershell completion upstream spf13/cobra#1208 All my changes are in there :)

[Luap99]

I can't really review this: I've never actually used MS Windows. I have no way to know if this will work, or to verify your Get-Help or other man page instructions.

You could theoretically install powershell on linux. Not that you would ever want or need that.
https://docs.microsoft.com/en-gb/powershell/scripting/install/installing-powershell-core-on-linux?view=powershell-7.1

[TomSweeneyRedHat]

I've a few man page changes to consider. The code looks fine with an eyeball revied, but like @edsantiago, I don't have an easy way to test it at the moment.

[vrothberg]

Friendly ping (going through PRs at the moment)

[Luap99]

Updated with @TomSweeneyRedHat doc fixes.

If you want to test it you can run the following. Make sure you have the podman service is running.

$ make podman-remote-static
$ podman run -it -v $(pwd)/bin/podman-remote-static:/bin/podman-remote -v /run/user/1000/podman/podman.sock:/run/podman/podman.sock   --security-opt label=disable  --rm mcr.microsoft.com/powershell
PowerShell 7.1.2
Copyright (c) Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

PS /> podman-remote completion powershell | Out-String | Invoke-Expression
PS /> podman-remote [TAB]

[rhatdan]

LGTM

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[edsantiago]

/lgtm
/hold

Sorry about spacing out on this. Holding because I get nervous when merging from an old base; I'll leave you the choice of unholding or rebasing. If you rebase, I promise to re-lgtm ASAP.

[Luap99]

I lost track of this as well. I rebased, better than breaking the CI.

[edsantiago]

/lgtm
/hold

[edsantiago]

/hold cancel