Should send the OCI runtime path not just the name to buildah #9906
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
[NO TESTS NEEDED] Mainly because I have no idea how we would test this. Fixes: containers#9459 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
changed the title
|
LGTM |
| // Make sure that build containers use the same runtime as Podman (see #9365). | ||
| conf := util.DefaultContainerConfig() | ||
| options.Runtime = conf.Engine.OCIRuntime | ||
| options.Runtime = r.GetOCIRuntimePath() |
There was a problem hiding this comment.
Could the default runtime ever differ from what's set in the containerConfig structure? If so, I'm not sure we'd want to do this.
There was a problem hiding this comment.
They are stored in the same structure. We read it originally from the containers.conf, but if the user overrides it, we replace the value in the same structure.
|
One question, if I'm off base with it, then LGTM. |
github-actions
bot
added
the
locked - please file new issue/PR
[NO TESTS NEEDED] Mainly because I have no idea how we would test
this.
Fixes: #9459
Signed-off-by: Daniel J Walsh dwalsh@redhat.com