Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qm.if: qemu + gtk display with wayland #516

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

aesteve-rh
Copy link
Collaborator

These rules are collected for an scenario
where a Qemu KVM container runs with GTK
display and Wayland compositor.

@dougsland
Copy link
Collaborator

dougsland commented Aug 26, 2024

This is awesome @aesteve-rh - have you tested this one in your autosd ?
@rhatdan @Yarboa WDYT?

@dougsland dougsland added the enhancement New feature or request label Aug 26, 2024
@dougsland
Copy link
Collaborator

@aesteve-rh if you don't have a JIRA for this one, let's tag jira so the system can create a JIRA ticket for you downstream so your work can be visible in all spaces. Thank you!

cc @sandrobonazzola

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aesteve-rh
Copy link
Collaborator Author

have you tested this one in your autosd ?

Yes, I did a little example scenario with autosd-demo for this. Since we had support already for wayland, it was relatively easy to isolate the rules that concern kvm workloads. I am now working towards doing the same but with qemu+dbus display, but it is still WiP. That would require more rules, and thus, a follow-up PR.

if you don't have a JIRA for this one

Technically, I do, but the ticket's criteria assumes full kvm support. And that will depend on the dbus display scenario.

@dougsland
Copy link
Collaborator

LGTM, lets wait @rhatdan for the final review.

@dougsland dougsland added the jira label Aug 30, 2024
These rules are collected for an scenario
where a Qemu KVM container runs with GTK
display and Wayland compositor.

Signed-off-by: Albert Esteve <aesteve@redhat.com>
Copy link
Collaborator

@alexlarsson alexlarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhatdan
Copy link
Member

rhatdan commented Sep 3, 2024

LGTM

@rhatdan rhatdan merged commit dbc6c64 into containers:main Sep 3, 2024
10 checks passed
@aesteve-rh aesteve-rh deleted the qemu-kvm branch September 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants