-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase for Check if QM is installed #537
Conversation
@dougsland @pengshanyu @Yarboa I checked that on the VM there was no podman installed before testing it, then I ran the tmt like so: The result was:
On VM I checked that it installed podman-5.2.2-1.el9.x86_64 and had not ran the QM at all: |
@nsednev |
@nsednev from the output I see your are kindly not using the right patch maybe?
This part of code is weird to my eyes, could you please share the code? First, should be |
Tested on distro: CentOS Stream 9: No podman and qm installed on clean and fresh OS: Running tmt tier-0 against VM:
total: 6 tests passed On VM I see: [root@ibm-p8-kvm-03-guest-02 ~]# podman ps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, needs just small changes.
and of course, pass in ci/cd |
Signed-off-by: nsednev <nsednev@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougsland
This scenario is tested manually, in ci/cd there is already qm installed
either on osbuild regular image or the gate, since new rpm created in pipeline and installed before tests begin
this sufficient i assume
#537
#521 (comment)
Fix #521
This is a REBASE for patch for set-ffi-env-e2e forth to #521 .
It checks if the QM rpm package was installed on host.