/var/qm test #552
Merged
/var/qm test #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
The shebang (#!) at the beginning of the line indicates that the script should be executed using the specified interpreter, which in this case is /bin/bash. This means that the script will be run using the Bash shell. Signed-off-by: nsednev <nsednev@redhat.com> Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
No need to be specific for disk, lets to the whole thing Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
on SoC stop qm mounting check if parted is installed Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
Yarboa
requested review from
rhatdan,
lsm5,
dougsland and
sandrobonazzola
as code owners
|
@dougsland please review So script is good |
|
I'd merge what we have now working, tag, release and that's it. |
@dougsland please review, rebase and comment |
|
if works for SoC and upstream, let's merge now. We can always improve later. I will tag it and make a release. |
|
Thanks for your efforts downstream @Yarboa ! |
This was referenced Sep 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on this #538
Tested on soc c9s manually