Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pushing from one type of AI Image to an OCI Image #245

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 7, 2024

This PR allows users to push images pulled as one type and then push them to an OCI Registry.

For example
ramalama pull tiny
ramalama push tiny quay.io/myregistry/tiny:latest

@rhatdan
Copy link
Member Author

rhatdan commented Oct 7, 2024

This is WIP because omlmd/oras are currently broken since they do not allow pushing of files with ":" in them.

I opened oras-project/oras-py#161 to move this forward.

@rhatdan
Copy link
Member Author

rhatdan commented Oct 7, 2024

@tarilabs PTAL

@rhatdan rhatdan force-pushed the push branch 4 times, most recently from 2d943d5 to ea928d8 Compare October 7, 2024 20:18
This PR allows users to push images pulled as one type
and then push them to an OCI Registry.

For example
ramalama pull tiny
ramalama push tiny quay.io/myregistry/tiny:latest

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@tarilabs
Copy link
Member

tarilabs commented Oct 8, 2024

I opened oras-project/oras-py#161 to move this forward.

Thank you; I've added some suggestions and consideration to the PR you raised; hope that helps

Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any immediate issue here, this is still marked WIP though

@rhatdan
Copy link
Member Author

rhatdan commented Oct 9, 2024

We can probably merge, but I was waiting for upstream ORAS PR to merge, since the primary goal here is to allow pulling of Ollama and HuggingFace images and pushing them as OCI Artifacts.

@rhatdan rhatdan changed the title [WIP] Allow pushing from one type of AI Image to an OCI Image Allow pushing from one type of AI Image to an OCI Image Oct 9, 2024
@ericcurtin ericcurtin merged commit a362939 into containers:main Oct 9, 2024
11 checks passed
@tarilabs
Copy link
Member

fwiw #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants