-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] Tag 1.6.2 #1613
[release-1.6] Tag 1.6.2 #1613
Conversation
- Bump github.com/prometheus/client_golang to v1.11.1 - Update the command to install golint Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the release branch itself with the backported commit would suffice for @jnovy's needs. But, I'm cool either way. LGTM.
I did not think we did -dev tags in released branches? |
It’s quite possible, in that case I’m just unaware of that convention. In the Skopeo context, historical practice varies. (I think some marker to make sure the 1.6.2 release is unambiguous, even if we latter use the branch, is valuable. I don’t care about the particular name, if |
@jnovy After this PR, there would be a version This would only affect about the version reported in any future cherry-pick, if it happened without tagging a post-v1.6.2 release. From the upstream perspective, it is valuable to be able to differentiate the “real” v1.6.2 from a cherry-pick of a different tree. |
@mtrmac "-maint" could do if you prefer a tag to be added to the maintenance branch IMO. |
I think it is fine to leave it, but we almost always do a back port and cut a release. We don't have long lasting changes to a release branch. |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Updated the post-release version to 1.6.2-maint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging so that this doesn’t block packaging work; we can adjust the post-release name later. |
No description provided.