Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] 1.9 backports #1784

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Oct 19, 2022

Just containers/image#1695 + tagging 1.9.3.

1.19 has changed the expected gofmt format, and we don't want
to follow such changes on the stable branch.

go@1.18 is "keg-only", i.e. not installed by Brew to /usr/local/bin,
so we need to change PATH to point at it (as the installation instructs
us to).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
> go get github.com/containers/image/v5@v5.22.1
> make vendor

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

needed for RHEL 8.7.0ZeroDay to be created from https://bugzilla.redhat.com/show_bug.cgi?id=2135973

@mtrmac
Copy link
Contributor Author

mtrmac commented Oct 19, 2022

Podman has a test failure, investigating…

@mtrmac
Copy link
Contributor Author

mtrmac commented Oct 19, 2022

Oh well, Podman passed on a re-run.

@mtrmac mtrmac merged commit 04d99f7 into containers:release-1.9 Oct 19, 2022
@mtrmac mtrmac deleted the 1.9-backports branch October 19, 2022 19:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants