Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Use human-readable CI VM Images #1888

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented Jan 30, 2023

Image content hasn't changed much, the biggest thing here is the $IMAGE_SUFFIX value. This new schema is also fully manageable by renovate. Allowing a tag-push to c/automation_images to create image update PRs in all repos automatically.

Ref: containers/automation_images#247

Signed-off-by: Chris Evich cevich@redhat.com

@cevich cevich changed the title Cirrus: Use human-readable CI VM Images [WIP] Cirrus: Use human-readable CI VM Images Jan 30, 2023
@cevich cevich marked this pull request as draft January 30, 2023 15:26
@cevich cevich changed the title [WIP] Cirrus: Use human-readable CI VM Images Cirrus: Use human-readable CI VM Images Jan 31, 2023
@cevich cevich marked this pull request as ready for review January 31, 2023 22:00
@cevich cevich requested a review from mtrmac January 31, 2023 22:00
@cevich
Copy link
Member Author

cevich commented Jan 31, 2023

@mtrmac this one is ready but...I had to re-run Skopeo Test much more than I would like. They all seem like quay or networking-related flakes though, so 🤷‍♂️ not sure there's much that we can do.

Image content hasn't changed much, the biggest thing here is the
`$IMAGE_SUFFIX` value.  This new schema is also fully manageable
by renovate.  Allowing a tag-push to c/automation_images to create image
update PRs in all repos automatically.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the managed_ci_vm_images branch from 909e448 to f9406bb Compare January 31, 2023 22:03
@cevich
Copy link
Member Author

cevich commented Jan 31, 2023

force-push: rebased (and fingers-crossed)

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM, feel free to merge after tests pass.

@mtrmac mtrmac merged commit ce16b5b into containers:main Feb 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants