Packit: easier to read distro conditionals #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
changed the title
|
Ignore until koji and copr builds verified. |
|
copr build looks fine: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/6087595/ PTAL. |
|
I think I can also get rid of a lot of the |
adding more cleanups |
lsm5
force-pushed
the
packit-cleanup
branch
3 times, most recently
from
37ccc27 to
8c3e773
Compare
lsm5
changed the title
|
@mtrmac PTAL. spec file should be much easier to read now. |
Distro conditionals have been rewritten in a cleaner and easier to read way. All `bcond` macros have been replaced with friendlier alternatives. Also removed macros related to `import_path` as they are no longer necessary. update-spec-provides.sh has been updated to account for possible build issues in downstream tasks which won't be noticed until a downstream release. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
mtrmac
approved these changes
Jun 26, 2023
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distro conditionals have been rewritten in a cleaner
and easier to read way.
All
bcondmacros have been replaced with friendlier alternatives.Also removed macros related to
import_pathas they are no longernecessary.