Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] RPM: fix ELN builds #2026

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[CI:BUILD] RPM: fix ELN builds #2026

merged 1 commit into from
Jun 28, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jun 28, 2023

For Fedora, we need to ensure ELN builds are successful.

The recent skopeo builds have been failing on copr because of /usr/bin/go-md2man being available via different package names. https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6119200/

This commit changes go-md2man dependency directly on the binary path instead of a pacakge.

ELN scratch builds are now successful:
https://koji.fedoraproject.org/koji/taskinfo?taskID=102706281

For Fedora, we need to ensure ELN builds are successful.

The recent skopeo builds have been failing on copr because of
/usr/bin/go-md2man being available via different package names.
https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6119200/

This commit changes go-md2man dependency directly on the
binary path instead of a pacakge.

ELN scratch builds are now successful:
https://koji.fedoraproject.org/koji/taskinfo?taskID=102706281

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 changed the title RPM: fix ELN builds [CI:BUILD] RPM: fix ELN builds Jun 28, 2023
@lsm5
Copy link
Member Author

lsm5 commented Jun 28, 2023

I'll add ELN builds to the CI task list for PRs once everything has been known to be smooth in official Koji builds and after-commit copr builds. Mainly because, adding them to the task list and then disabling them for whatever reason can be a lot of trouble especially when dealing with multiple repos.

@lsm5 lsm5 marked this pull request as ready for review June 28, 2023 14:55
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit bf7ae0a into containers:main Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
@lsm5 lsm5 deleted the rpm-eln-fix branch December 19, 2024 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants