Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] GHA: Closed issue/PR comment-lock #2090

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 22, 2023

Lock discussions on closed PRs and Issues after 90-days of inactivity.

Ref:
containers/podman#19012
and
containers/podman#19691
and
containers/podman#19700

@cevich
Copy link
Member Author

cevich commented Aug 22, 2023

Note: Leaving this marked draft on purpose:

@mtrmac
Copy link
Contributor

mtrmac commented Aug 22, 2023

FWIW I don’t care strongly either way — comments on old closed issues are fairly rare here, IIRC (certainly compared to some Podman issues).

I think just being consistent with the other repos is the decisive factor, and a reason to enable this.

@cevich
Copy link
Member Author

cevich commented Aug 22, 2023

I think just being consistent with the other repos is the decisive factor, and a reason to enable this.

Thanks for the feedback, yeah that's a good point. Still, let's make sure the workflow-reuse call works on buildah first. It's really easy to screw these things up, and unhelpful there's no way to test it in a PR 😞

@cevich cevich force-pushed the lock_closed_issues_prs branch from 8fb24ad to d47c946 Compare August 28, 2023 16:02
Lock discussions on closed PRs and Issues after 90-days of inactivity.

Ref:
     containers/podman#19012
and
     containers/podman#19691
and
     containers/podman#19700

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the lock_closed_issues_prs branch from d47c946 to 2976f4f Compare August 28, 2023 16:03
@cevich
Copy link
Member Author

cevich commented Aug 28, 2023

Force-push: Rebased & Added necessary permissions fix. Confirmed job is working in buildah repo.

@cevich cevich changed the title [skip-ci] GHA: Closed issue/PR comment-lock test [skip-ci] GHA: Closed issue/PR comment-lock Aug 28, 2023
@cevich cevich marked this pull request as ready for review August 28, 2023 16:04
@rhatdan
Copy link
Member

rhatdan commented Sep 14, 2023

@cevich is this ready to go in?

@cevich
Copy link
Member Author

cevich commented Sep 14, 2023

Oh my bad, I thought this went in. Yep it's ready to go.

@mtrmac mtrmac merged commit 6998e7e into containers:main Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants