Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packit c10s #2312

Merged
merged 2 commits into from
May 6, 2024
Merged

Packit c10s #2312

merged 2 commits into from
May 6, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 2, 2024 •
edited
Loading

This commit will enable downstream syncing to CentOS Stream 10. The
centos maintainer will need to manually run packit propose-downstream
and centpkg build until better centos integration is in place.

This commit also builds both rhel9 and centos9 copr rpms so we can check
for things like differences in golang compiler.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member Author

lsm5 commented May 3, 2024

@mtrmac PTAL. the centos-stream builds are failing on ecdsa.HashSign while the epel builds (use RHEL + EPEL) passed because of an older golang compiler. Having both epel and centos-stream would be useful for such cases.

The change in the PR itself should be good to go.

@lsm5 lsm5 marked this pull request as ready for review May 3, 2024 18:06
mtrmac
mtrmac approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac
Copy link
Contributor

mtrmac commented May 6, 2024

The EPEL-9 builds are reported as successful in COPR, but still pending in Packit.

I’ll try rebasing this PR to re-trigger builds…

@lsm5
Copy link
Member Author

lsm5 commented May 6, 2024

The EPEL-9 builds are reported as successful in COPR, but still pending in Packit.

I’ll try rebasing this PR to re-trigger builds…

oh actually that may have been packit getting confused because of the centos-stream and epel jobs having same parameters with different targets. Let me push an additional change to include a distinct packages key.

lsm5 added 2 commits May 6, 2024 13:34
@lsm5
[skip-ci] Packit: delete EL8 jobs
f94f7d2 
EL8 will go EOL soon and we won't be shipping anything there from main
until then.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
[skip-ci] Packit: enable c10s downstream sync
4909f12 
This commit will enable downstream syncing to CentOS Stream 10. The
centos maintainer will need to manually run `packit propose-downstream`
and `centpkg build` until better centos integration is in place.

This commit also builds both rhel9 and centos9 copr rpms so we can check
for things like differences in golang compiler.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@mtrmac
Copy link
Contributor

mtrmac commented May 6, 2024

@lsm5 Thanks. All but centos-stream is now passing. If this looks good, please merge.

@lsm5 lsm5 merged commit 1d70f69 into containers:main May 6, 2024
22 of 26 checks passed
@lsm5
Copy link
Member Author

lsm5 commented May 6, 2024

@lsm5 Thanks. All but centos-stream is now passing. If this looks good, please merge.

Thanks a lot @mtrmac

@lsm5 lsm5 deleted the packit-c10s branch May 6, 2024 18:06
@mtrmac mtrmac mentioned this pull request May 27, 2024
Merged
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @mtrmac