Update to containers/image/v5 #748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| before_install: | ||
| - sudo add-apt-repository -y ppa:projectatomic/ppa | ||
| - sudo apt-get update | ||
| - sudo podman |
|
5 hour test cycle is a little odd, it's still cranking. |
> gomove github.com/containers/image/v4 github.com/containers/image/v5 > GO111MODULE=on go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@release-5 > GO111MODULE=on go get github.com/containers/image/v5 > make vendor Also add make vendor-in-container, to allow golang 1.13 vendoring. Signed-off-by: Miloslav Trmač <mitr@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Travis seems to have an issue reporting. I restarted the tests to look into it. Regarding the PR. I would have preferred to split the |
|
The CI is still calling |
|
v5 vendoring #749 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #747
Signed-off-by: Miloslav Trmač mitr@redhat.com
Signed-off-by: Daniel J Walsh dwalsh@redhat.com