remove direct reference on c/image/storage #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a direct reference on c/image/v5/storage which breaks the build when using the `containers_image_storage_stub`. The reference is only used to get the storage tranport string, which is now hard-coded; this is fine as the transport will not change for backwards compat. Fixes: containers#771 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
mtrmac
reviewed
Dec 9, 2019
There was a problem hiding this comment.
This works (feel free to merge).
Another alternative to consider would be to gate this code behind the containers_image_storage_stub build tag instead — that would be cleaner in using a Go-visible value reference instead of a magic constant, but less clean in hard-coding c/image build tags in a different project. Purely on principle, it seems a bit better to me, OTOH it’s notably more work for a rare case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a direct reference on c/image/v5/storage which breaks the build
when using the
containers_image_storage_stub. The reference is onlyused to get the storage tranport string, which is now hard-coded; this
is fine as the transport will not change for backwards compat.
Fixes: #771
Signed-off-by: Valentin Rothberg rothberg@redhat.com